SMF Shop

SMFShop => SMFShop Announcements => Topic started by: Daniel15 on January 19, 2007, 07:00:53 pm

Title: Known bugs in SMFShop 3.0
Post by: Daniel15 on January 19, 2007, 07:00:53 pm
This page has been moved to the Wiki - http://www.daniel15.com/smfshop_wiki/Bugs
Title: Re: Known bugs in SMFShop 3.0
Post by: eugeniu on January 20, 2007, 05:46:33 am
SOMETHING IS SCREWIN WRONG WITH MY SMF-SHOP !!! :tickedoff:
See for yourself. (http://www.fuzillion.com/forums/index.php?action=shop)
And I can't go to the shop items through the admin panel because they don't show up, so I can't save my items!!!! :buck2:
What's going on???
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on January 20, 2007, 09:14:36 pm
eugeniu, try copying the Shop.template.php file from the SMFShop archive to Themes/default/Shop.template.php. That should fix your problem.
Title: Re: Known bugs in SMFShop 3.0
Post by: jdv on January 20, 2007, 10:57:07 pm
Where is the archive?
Title: Re: Known bugs in SMFShop 3.0
Post by: eugeniu on January 21, 2007, 02:01:45 am
eugeniu, try copying the Shop.template.php file from the SMFShop archive to Themes/default/Shop.template.php. That should fix your problem.

It still does the same thing.  :'( :'( :'( :'( :'( :'(
Title: Re: Known bugs in SMFShop 3.0
Post by: thelastkiss on January 21, 2007, 04:36:36 am
Hi Daniel,

Another "bug" (I don't know if there is a fix for this) - whenever I click on "View Member's Inventory" in a thread, I get "Error - this member does not exist!"

However, if I view their inventory in the shop, everything is working as usual. :)
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on January 21, 2007, 02:19:33 pm
Quote
Where is the archive?
Sorry about that, I meant the SMFShop download on the DanSoft Australia website. If you downloaded SMFShop on or after January 19th, both bugs are already fixed :)

Quote
Another "bug" (I don't know if there is a fix for this) - whenever I click on "View Member's Inventory" in a thread, I get "Error - this member does not exist!"

However, if I view their inventory in the shop, everything is working as usual.
Thanks for the bug report, I'll update my post above with information on how to fix this :)
Title: Re: Known bugs in SMFShop 3.0
Post by: jdv on January 21, 2007, 02:49:14 pm
i updated before, could you simply let me know the fix for the problem: (dont wanna upgrade again)

hen you send money to someone, it says your username in the message ("xx credits successfully sent to [your username]"), rather than the name of the user you're sending money to
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on January 22, 2007, 01:24:15 pm
jdv, as I mentioned before, the fix is above:
Quote
When you send money to someone, it says your username in the message ("xx credits successfully sent to [your username]"), rather than the name of the user you're sending money to. To fix this, open Sources/Shop/Shop-Send.php, and find:
Code: (php) [Select]
$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $context['user']['name']);Replace with:
Code: (php) [Select]
$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $moneyTo);
Title: Re: Known bugs in SMFShop 3.0
Post by: eugeniu on January 27, 2007, 06:59:05 am
Auuuggggh! :tickedoff:

I recorded everyone's credits, uninstalled SMFShop, installed v3.0, I see the credits on the right of every post, but when want to go to the shop, it just goes to the index!!!!!!! And I don't see the Shop buttons in the admin area!!!!

http://www.fuzillion.com/forums/index.php

 :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :buck2:
Title: Re: Known bugs in SMFShop 3.0
Post by: feeble on January 30, 2007, 03:10:07 pm
not really bug, but breaks your install zip if you have certain mods installed other then smfshop

can you please amend for a future update if possible
Code: [Select]
<file name="$sourcedir/ManagePermissions.php">
<operation>
<search position="before"><![CDATA[
'who_view' => false,
'search_posts' => false,
'karma_edit' => false,
),
]]></search>
<add><![CDATA[
// Begin SMFShop code
'shop' => array(
'shop_main' => false,
'shop_buy' => false,
'shop_invother' => false,
'shop_sendmoney' => false,
'shop_senditems' => false,
'shop_bank' => false,
'shop_trade' => false,
),
// End SMFShop code
]]></add>
</operation>
</file>

to
Code: [Select]
<file name="$sourcedir/ManagePermissions.php">
<operation>
<search position="before"><![CDATA[
'who_view' => false,
'search_posts' => false,
'karma_edit' => false,
]]></search>
<add><![CDATA[
// Begin SMFShop code
'shop' => array(
'shop_main' => false,
'shop_buy' => false,
'shop_invother' => false,
'shop_sendmoney' => false,
'shop_senditems' => false,
'shop_bank' => false,
'shop_trade' => false,
// End SMFShop code
]]></add>
</operation>
</file>
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on February 03, 2007, 09:06:01 am
Auuuggggh! :tickedoff:

I recorded everyone's credits, uninstalled SMFShop, installed v3.0, I see the credits on the right of every post, but when want to go to the shop, it just goes to the index!!!!!!! And I don't see the Shop buttons in the admin area!!!!

http://www.fuzillion.com/forums/index.php

 :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :'( :buck2:

Check if your index.php file was edited with SMFShop stuff. If it wasn't, upload the SMFShop package to http://server.daniel15.com/smf/package.php, and do the index.php edit.

not really bug, but breaks your install zip if you have certain mods installed other then smfshop

can you please amend for a future update if possible
Those edits look like they will break the code. Have you tried this yourself?
Title: Re: Known bugs in SMFShop 3.0
Post by: feeble on February 03, 2007, 03:21:35 pm
Quote
Those edits look like they will break the code. Have you tried this yourself?
no, i replaced the ManagePermissions.php manually straight after i installed the package whilst having the error, but that is where is where it was having the trouble.

essentially, the g2+smf package changes the file to
Code: [Select]
'who_view' => false,
'search_posts' => false,
'karma_edit' => false,
'gallery' => false,
),

which breaks your install.

again, since most ppl don't use gallery2(for some bizarre reason ;) its not really an issue for most users
Title: Re: Known bugs in SMFShop 3.0
Post by: perplexed on February 08, 2007, 06:45:55 am
what's gallery2?  do you mean the new smf gallery mod or the external gallery that's like coppermine?

just curious as I have gallery mod & shop 2.3 and was intending to keep both when I upgrade
Title: Re: Known bugs in SMFShop 3.0
Post by: feeble on February 08, 2007, 02:11:42 pm
what's gallery2?  do you mean the new smf gallery mod or the external gallery that's like coppermine?

just curious as I have gallery mod & shop 2.3 and was intending to keep both when I upgrade

Oldiesman SMF+G2 Project (http://smf.oldiesmann.us/galleryproject/index.php)

i do have SMFShop 3.0 and SMF+G2 V3 running together, just took awhile, because SMF+G2 package install breaks the SMFShop 3.0 Package
Title: Re: Known bugs in SMFShop 3.0
Post by: perplexed on February 14, 2007, 07:30:33 pm
jdv, as I mentioned before, the fix is above:
Quote
When you send money to someone, it says your username in the message ("xx credits successfully sent to [your username]"), rather than the name of the user you're sending money to. To fix this, open Sources/Shop/Shop-Send.php, and find:
Code: (php) [Select]
$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $context['user']['name']);Replace with:
Code: (php) [Select]
$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $moneyTo);


Hi Daniel

Just reading the bugs and went to fix this in my 3.0 shop but my file says this:

Code: [Select]
// Tell the user that their request was successful
//$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $context['user']['name']);
$context['shop_buy_message'] = sprintf($txt['shop_successfull_send'], formatMoney($amount), $moneyTo);

}
  so the code you say to replace is already there?  Do I still have to do something?
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on February 17, 2007, 09:43:48 am
Quote
Do I still have to do something?
Nope, it's been fixed .This is just kept here for reference purposes :)
Title: Re: Known bugs in SMFShop 3.0
Post by: myg_weng on February 25, 2007, 02:44:00 pm
what does this do in the steal.php part  line 72?

      $_POST['username'] = strtr($_POST['username'], array('\\"' => '"'));
      preg_match_all('~"([^"]+)"~', $_POST['username'], $matches);
      $userArray = array_unique(array_merge($matches[1], explode(',', preg_replace('~"([^"]+)"~', '', $_POST['username']))));


----

i think the steal.php is not working on my site... i have increased the probability to 100%

ERROR :

8: Undefined index: username
File: /home2/mygimm75/public_html/myg/smf111b/Sources/shop/items/Steal.php
Line: 72


-------

cant we not just point $username to the typed user?
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on February 25, 2007, 05:28:16 pm
Quote
i think the steal.php is not working on my site... i have increased the probability to 100%

ERROR :

8: Undefined index: username
File: /home2/mygimm75/public_html/myg/smf111b/Sources/shop/items/Steal.php
Line: 72
I could swear I fixed that bug... The fix is at http://www.daniel15.com/forum/index.php/topic,559.0.html.

Quote
what does this do in the steal.php part  line 72?

      $_POST['username'] = strtr($_POST['username'], array('\\"' => '"'));
      preg_match_all('~"([^"]+)"~', $_POST['username'], $matches);
      $userArray = array_unique(array_merge($matches[1], explode(',', preg_replace('~"([^"]+)"~', '', $_POST['username']))));
That code basically removes the "s from the names, and splits them into an array. This is needed so it's compatible with SMF 1.1 (which adds quotation marks around the name)
Title: Re: Known bugs in SMFShop 3.0
Post by: myg_weng on February 25, 2007, 11:00:06 pm
i think $_POST['username']  should be $_POST['stealname']


:D

..im using RS3 by the way
Title: Re: Known bugs in SMFShop 3.0
Post by: Daniel15 on February 26, 2007, 06:17:42 pm
Quote
i think $_POST['username']  should be $_POST['stealname']
Yep, that's mentioned in the post I linked to ;).
Title: Re: Known bugs in SMFShop 3.0
Post by: inkstains on March 14, 2007, 07:36:30 pm
Is there a problem installing this on smf 1.1.2? i've got a clean forum install no other mods and when i got and install the shop it appears to work correctly yet i don't have any menu in admin or anything in the store besides a credit report stating i have 10000 credits i read the manage permissions post on page 1 of this thread though that didn't appear applicable to myself as i don't have gallery i still tried it but still no success i also tried copying Shop.template.php file from the SMFShop archive to Themes/default/Shop.template.php but no success there either i've also tried to download the archive again and reinstall but still no luck just wondering if i'm missing something

thanks


EDIT: I've done an upgrade on another forum that was 1.1 RC3 and that worked a treat but i'd still like to get this running on my other forum as well which is 1.1.2


cheers heaps
Title: Re: Known bugs in SMFShop 3.0
Post by: yopo on October 24, 2008, 10:51:47 pm
smfshop dont work in my forum.
i have SMF 1.1.5 and i can't install the mode
i go to Packet and run them but its type Eror ..
Help meee  :-[